Quantcast
Channel: Active questions tagged excel - Stack Overflow
Viewing all articles
Browse latest Browse all 90251
↧

Is it possible to make the following macro smaller and more efficient? [closed]

March 13, 2020, 12:54 am
$
0
0

I have created the following macro to run a spreadsheet. Can anyone suggest making it shorter and more efficient.

I tried to at least to add values in alternative columns minimize the use of if conditions but couldn't figure it out with the time limit I have. 

Sub SubContractorClaim()

Dim lastrow As Long
Dim i As Integer

lastrow = Worksheets("Return of Works").Cells(Rows.Count, 2).End(xlUp).Row





     For i = 24 To lastrow

         Worksheets("Return of Works").Cells(i, 7).ClearContents


         If Worksheets("Return of Works").Cells(i, 8) > 0 And Worksheets("Return of Works").Cells(i, 6) > 0 Then
         Worksheets("Return of Works").Cells(i, 7) = Worksheets("Return of Works").Cells(i, 8) / Worksheets("Return of Works").Cells(i, 6)
         ElseIf Worksheets("Return of Works").Cells(i, 8) = "" Then
         Worksheets("Return of Works").Cells(i, 7) = ""

         End If

         Worksheets("Return of Works").Cells(i, 7).NumberFormat = "0.00%"

         Worksheets("Return of Works").Cells(i, 9).ClearContents

         If Worksheets("Return of Works").Cells(i, 10) > 0 And Worksheets("Return of Works").Cells(i, 6) > 0 Then
         Worksheets("Return of Works").Cells(i, 9) = Worksheets("Return of Works").Cells(i, 10) / Worksheets("Return of Works").Cells(i, 6)
         ElseIf Worksheets("Return of Works").Cells(i, 10) = "" Then
         Worksheets("Return of Works").Cells(i, 9) = ""

         End If

         Worksheets("Return of Works").Cells(i, 9).NumberFormat = "0.00%"



         If Worksheets("Return of Works").Cells(7, 3) = 1 Then

         Worksheets("Return of Works").Cells(i, 18) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 17) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 2 Then
         Worksheets("Return of Works").Cells(i, 20) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 19) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 3 Then
         Worksheets("Return of Works").Cells(i, 22) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 21) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 4 Then
         Worksheets("Return of Works").Cells(i, 24) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 23) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 5 Then
         Worksheets("Return of Works").Cells(i, 26) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 25) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 6 Then
         Worksheets("Return of Works").Cells(i, 28) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 27) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 7 Then
         Worksheets("Return of Works").Cells(i, 30) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 29) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 8 Then
         Worksheets("Return of Works").Cells(i, 32) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 31) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 9 Then
         Worksheets("Return of Works").Cells(i, 34) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 33) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 10 Then
         Worksheets("Return of Works").Cells(i, 36) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 35) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 11 Then
         Worksheets("Return of Works").Cells(i, 38) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 37) = Worksheets("Return of Works").Cells(i, 9)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 12 Then
         Worksheets("Return of Works").Cells(i, 40) = Worksheets("Return of Works").Cells(i, 10)
         Worksheets("Return of Works").Cells(i, 39) = Worksheets("Return of Works").Cells(i, 9)


         End If


         If Worksheets("Return of Works").Cells(7, 3) = 1 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 2 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 3 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 4 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 5 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 6 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 7 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 8 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 9 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 10 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 11 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36) + Worksheets("Return of Works").Cells(i, 38)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 12 Then
         Worksheets("Return of works").Cells(i, 14) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36) + Worksheets("Return of Works").Cells(i, 38) + Worksheets("Return of Works").Cells(i, 40)

         End If

         Worksheets("Return of Works").Cells(i, 13).ClearContents

         If Worksheets("Return of Works").Cells(i, 14) > 0 And Worksheets("Return of Works").Cells(i, 6) > 0 Then
         Worksheets("Return of Works").Cells(i, 13) = Worksheets("Return of Works").Cells(i, 14) / Worksheets("Return of Works").Cells(i, 6)
         ElseIf Worksheets("Return of Works").Cells(i, 14) = "" Then
         Worksheets("Return of Works").Cells(i, 13) = ""

         End If


         If Worksheets("Return of Works").Cells(7, 3) = 1 Then
         Worksheets("Return of works").Cells(i, 12) = 0

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 2 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 3 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 4 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 4 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 5 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 6 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 7 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 8 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 9 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 10 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 11 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36) + Worksheets("Return of Works").Cells(i, 38)

         ElseIf Worksheets("Return of Works").Cells(7, 3) = 12 Then
         Worksheets("Return of works").Cells(i, 12) = Worksheets("Return of Works").Cells(i, 18) + Worksheets("Return of Works").Cells(i, 20) + Worksheets("Return of Works").Cells(i, 22) + Worksheets("Return of Works").Cells(i, 24) + Worksheets("Return of Works").Cells(i, 26) + Worksheets("Return of Works").Cells(i, 28) + Worksheets("Return of Works").Cells(i, 30) + Worksheets("Return of Works").Cells(i, 32) + Worksheets("Return of Works").Cells(i, 34) + Worksheets("Return of Works").Cells(i, 36) + Worksheets("Return of Works").Cells(i, 38) + Worksheets("Return of Works").Cells(i, 40)


         End If

         Worksheets("Return of Works").Cells(i, 11).ClearContents

         If Worksheets("Return of Works").Cells(i, 12) > 0 And Worksheets("Return of Works").Cells(i, 6) > 0 Then
         Worksheets("Return of Works").Cells(i, 11) = Worksheets("Return of Works").Cells(i, 12) / Worksheets("Return of Works").Cells(i, 6)
         ElseIf Worksheets("Return of Works").Cells(i, 12) = "" Then
         Worksheets("Return of Works").Cells(i, 11) = ""

         End If

         If Worksheets("Return of Works").Cells(i, 6) = "" Then
         Worksheets("Return of Works").Cells(i, 12) = ""
         Worksheets("Return of Works").Cells(i, 13) = ""
         Worksheets("Return of Works").Cells(i, 14) = ""

         End If


         If Worksheets("Return of Works").Cells(i, 14) > Worksheets("Return of Works").Cells(i, 6) Then
         Worksheets("Return of Works").Cells(i, 14).Interior.Color = RGB(255, 0, 0)
         MsgBox "Error! Check Column J. Approved total claim value cannot be greater than contract value"

         End If
     Next

End Sub
↧
Search
Viewing all articles
Browse latest Browse all 90251

Trending Articles

RAMAYAMPET Mandal Sarpanch | Upa-Sarpanch | Ward member Mobile Numbers Medak...

May 24, 2017, 2:00 am

लड़कियां सेक्स के दौरान क्यों करती है उह! आह!लड़कियां सेक्स के दौरान क्यों करती...

May 19, 2016, 1:54 am

Neem Baba Extra Questions Answer Class 6 English Poorvi

February 1, 2025, 5:19 am

Throw Back: 4×4 — Sikilitele (Ft Castro) Prod by JQ

March 5, 2015, 8:24 am

Rajasthan Board 10th Result 2016 Roll No wise & Name Wise

August 20, 2016, 5:13 pm

Lowe faces four theft charges

November 14, 2017, 6:52 pm

Practice Sheet of Right form of verbs for HSC Students

September 22, 2019, 11:40 pm

Mafia, Murder & Mayhem In The Motor City: Detroit Mob Hit Timeline (1937-2007)

December 7, 2016, 3:57 pm

The 10 Tennessee Cities With The Largest Black Population For 2021

December 21, 2020, 10:12 am

Materials Around Us Class 6 Worksheet Science Chapter 6

October 3, 2024, 5:20 am

デスクトップ ヒープの枯渇

January 18, 2018, 8:31 pm

Best Suvichar in Hindi |बेस्ट सुविचार |शुभ विचार हिंदी में

March 7, 2020, 11:19 pm

Kanulanu Thaake Lyrics and translation | Manam (2014)

May 9, 2014, 5:45 am

Korean Sex Porn Videos: XXX Videos & Free Porn Movies

May 30, 2025, 9:29 pm

Teen Shot In Miami Drive-By Dies From Injuries

August 8, 2011, 1:16 pm

Download: IQ Muzatasha feat Shy D & Pmj – Ulesi NiFertilizer Yamavuto

March 22, 2018, 7:23 pm

Mahakal Attitude Status

February 29, 2020, 9:52 am

Property developer set up cannabis factory to help pay off debts...

August 3, 2015, 2:29 am

♡

July 11, 2015, 6:15 am

KB: How to troubleshoot issues when adding a Hyper-V host in System Center...

August 14, 2012, 10:05 am
Search
<script src="https://jsc.adskeeper.com/r/s/rssing.com.1596347.js" async> </script>